Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing flow filter for multi essence and add format filter for sources #74

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

philipnbbc
Copy link
Contributor

Details

This PR adds the missing urn:x-nmos:format:multi format for the format flow filter option. This PR also adds the format filter option to the /sources endpoint.

Pivotal Story (if relevant)

Story URL: https://www.pivotaltracker.com/story/show/187955630

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@philipnbbc philipnbbc requested a review from a team as a code owner July 15, 2024 13:29
@j616 j616 self-assigned this Jul 15, 2024
Copy link
Contributor

@j616 j616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipnbbc philipnbbc merged commit 3fc05d3 into main Jul 18, 2024
5 checks passed
@philipnbbc philipnbbc deleted the philipn-flow-filter-multi-format branch July 18, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants